Ignore exception on cancel/fail race in CancellableContinuation #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
requested changes
Dec 17, 2018
common/kotlinx-coroutines-core-common/src/CancellableContinuationImpl.kt
Outdated
Show resolved
Hide resolved
common/kotlinx-coroutines-core-common/src/CancellableContinuationImpl.kt
Show resolved
Hide resolved
common/kotlinx-coroutines-core-common/src/CancellableContinuationImpl.kt
Outdated
Show resolved
Hide resolved
common/kotlinx-coroutines-core-common/src/CancellableContinuationImpl.kt
Outdated
Show resolved
Hide resolved
common/kotlinx-coroutines-core-common/src/CancellableContinuationImpl.kt
Outdated
Show resolved
Hide resolved
common/kotlinx-coroutines-core-common/src/CancellableContinuationImpl.kt
Outdated
Show resolved
Hide resolved
common/kotlinx-coroutines-core-common/src/CancellableContinuationImpl.kt
Show resolved
Hide resolved
There seems to be no other way to satisfactory fix the problem of a race between cancellation on CancellationContinuation and concurrent failure of the corresponding background process in a way the distinguishes "failure from cancellation attempt" from a "true failure" without placing undue burden on anyone who is implementing `await()` extension function for various future types. - Added testTimeoutCancellationFailRace that works as a perfect litmus test; being allowed to run for a while it reliably detects various problems in alternative approaches. - Optimized CancellableContinuationImpl; merged its code with AbstractContinuation class that is not needed as a separate class and removed. - Deprecated and hidden CancellableContinuation.initCancellability(); it is now always invoked after the end of the block that was passed to suspendCancellableCoroutine. - Deprecated `holdCancellability` parameter to an internal suspendAtomicCancellableCoroutine function. Fixes #892 Fixes #830
elizarov
force-pushed
the
cancel-fail-race
branch
from
2b86b09 to
4ad776f
Compare
|
All review issues were addressed. |
qwwdfsad
approved these changes
Dec 18, 2018
|
Are there any estimates about release date with this fix? |
|
@gildor 1.1.0-alpha today or tomorrow and 1.1.0 on Friday if everything goes well |
|
@qwwdfsad Great news, just in time, I just didn't want to release kotlin-coroutines-retrofit with workaround that uses internal API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be no other way to satisfactory fix the problem of a race between cancellation on CancellationContinuation and concurrent failure of the corresponding background process in a way the distinguishes "failure from cancellation attempt" from a "true failure" without placing undue burden on anyone who is implementing
await()extension function for various future types.holdCancellabilityparameter to an internal suspendAtomicCancellableCoroutine function.Fixes #892
Fixes #830